Re: [Boost-bugs] [Boost C++ Libraries] #13457: Windows port for 1.66.0 incorrectly includes NTVERP.H

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #13457: Windows port for 1.66.0 incorrectly includes NTVERP.H
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2018-05-03 02:05:40


#13457: Windows port for 1.66.0 incorrectly includes NTVERP.H
--------------------------------------+-----------------------------
  Reporter: Brian Catlin <BrianC@…> | Owner: Andrey Semashev
      Type: Bugs | Status: closed
 Milestone: To Be Determined | Component: winapi
   Version: Boost 1.66.0 | Severity: Showstopper
Resolution: invalid | Keywords: windows
--------------------------------------+-----------------------------

Comment (by Andrey Semashev):

 Arguably, you're not defining macros like `VER_PRODUCTBUILD`. You're not
 supposed to, anyway, because that is the Windows SDK version macro.

 I'm not sure what version information you mean, but if this is the target
 Windows version defined by `_WIN32_WINNT` or the API family defined by
 `WINAPI_FAMILY` then defining those in a header is error-prone because it
 can easily get you into trouble if you mess up include order.

-- 
Ticket URL: <https://svn.boost.org/trac10/ticket/13457#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2018-05-03 02:11:17 UTC