TestCmd.py: strings or lists as program name

From: Vladimir Prus (ghost_at_[hidden])
Date: 2003-04-04 03:23:16

While running tests on Windows, I've seen this:

H:\Work\boost\tools\build-cvs\test>Program Files\Python22\python.exe"
stage.py
STDOUT ============

STDERR ============

Traceback (most recent call last):
File "stage.py", line 30, in ?
File "BoostBuild.py", line 232, in run_build_system
File "TestCmd.py", line 410, in run
TypeError: popen3() argument 1 must be string, not list

The switch from passing strings to passing lists was done just a few days ago 
with a patch from Andre Hentz. Seems that Popen3 class accepts lists, but
popen3 function does not. Andre, what's the best way to address this?
For now, I've just comitted the attached patch.

The Python version is:
H:\Work\boost\tools\build-cvs\test>\Program Files\Python22\python.exe"
Python 2.2.2 (#37, Oct 14 2002, 17:02:34) [MSC 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.

TIA,
Volodya
 --------------Boundary-00=_SM8T8H6877XN13WP50GJ Content-Type: text/x-diff;
charset="us-ascii";
name="TestCmd.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="TestCmd.diff"

Index: TestCmd.py
===================================================================
RCS file: /cvsroot/boost/boost/tools/build/test/TestCmd.py,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- TestCmd.py	2 Apr 2003 12:43:05 -0000	1.7
+++ TestCmd.py	4 Apr 2003 07:50:36 -0000	1.8
@@ -407,7 +407,7 @@
try:
p = popen2.Popen3(cmd, 1)
except AttributeError:
- (tochild, fromchild, childerr) = os.popen3(cmd)
+ (tochild, fromchild, childerr) = os.popen3(join(cmd, " "))
if stdin:
if type(stdin) is ListType:
for line in stdin:
 --------------Boundary-00=_SM8T8H6877XN13WP50GJ--