registry access

From: Vladimir Prus (ghost_at_[hidden])
Date: 2003-10-22 01:49:22

Hi Paul,

pal.tw wrote:

> > I recall Matt Armstrong has implemented something similiar for this
>
> patched
>
> > version of Perforce Jam. Is it primarily used for detecting where
>
> msvc is
>
> > installed?
>
> yes.
>
> > I'm +/- 0 on this change, since we did not seen any complains from
>
> msvc users.

Per discussion which happened I agree that registry access would be good to 
have. I've some questions about your patch, though:

1. If "PROFILE" a good name. It has strong connection for performance 
measurements for me. In Matt's version it was called W32_GETREG. Maybe, some 
better name could be invented.

2. What happens for REG_SZ value type?

3. You use _ltoa function. Isn't it msvc-specific. If so, printf would be a 
portable alternative.

4. Finally, it seems like you profile.win32.c file has tabs. While Perforce 
Jam has them, it think it's better to avoid tabs in a new file.

- Volodya