Re: [jamboost] registry access

From: PAL (b84037_at_[hidden])
Date: 2003-10-22 09:50:10

> 1. If "PROFILE" a good name. It has strong connection for performance
> measurements for me. In Matt's version it was called W32_GETREG. Maybe,
some
> better name could be invented.
>
ha... I just name it temportarily. Sure, you can rename it with some proper
name.
My vocabulary is too small. I give the name because MS often uses the word
to name a configuration file or a stucture. And I assume that maybe
other platform would have a similar profile file.

> 2. What happens for REG_SZ value type?
>
Do you indicate this piece of code?
----------------------------------------------------------------------------
--------------------
case REG_DWORD: _ltoa( *(PDWORD)bsDataValue, bsDataValue, 10 );
case REG_SZ:
default: dlResult = list_new( dlResult, newstr(bsDataValue) ); break;
----------------------------------------------------------------------------
--------------------
REG_SZ value type is the same as other remaining type -- just a string.
Mmm....maybe I should remove the "case REG_SZ:".

> 3. You use _ltoa function. Isn't it msvc-specific. If so, printf would be
a
> portable alternative.
>
'_ltoa' is a MS extension for STD C Library since Windows 95 appeared,
and is implemented with C Runtime Library. It seems to be a part of APIs
win32 provides.
I am sure that it can be compiled with BCB/BCC or MinGW.
But I don't know if it is compiled with intel compiler or others since I
don't have them.
Can I wait for reports from others? If it isn't compiled, I will fix it by
using 'sprintf';

> 4. Finally, it seems like you profile.win32.c file has tabs. While
Perforce
> Jam has them, it think it's better to avoid tabs in a new file.
>
Yes, you are right. Thanks! I replace it with 4 spaces.
Although I use 4 spaces for indention, some of editors add 'tab'
automatically for me, like VS IDE.
And I often forget to replace them.
 ------=_NextPart_000_0022_01C398EE.D8EC0250 Content-Type: application/octet-stream;
name="jam_src.zip"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="jam_src.zip"

[Attachment content not displayed.] ------=_NextPart_000_0022_01C398EE.D8EC0250--