Re: Commented out test

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-01-04 05:34:25

On Sunday 02 January 2005 03:33, you wrote:
> >From print.jam:
>
> # VP, 2004-12-03 The following test fails for some reason,
> # so commenting it out.
> #assert.result "one two three" "&<>" :
> # escape-html "one two three" "&<>" ;
>
>
> Seeing this worries me greatly. A failing test should never just be
> commented out because we don't know why it's failing. Either determine
> that the test was wrong and remove it cleanly, or fix whatever is making
> it fail!

The attached message mentions this case. I was hoping Rene would comment.

- Volodya
 --Boundary-00=_yEn2B8rnXPjBSR6 Content-Type: message/rfc822;
name="forwarded message"
Content-Transfer-Encoding: 7bit
Content-Description: Vladimir Prus <ghost_at_[hidden]>: [jamboost] print module fails unit test
Content-Disposition: inline

Return-path: <sentto-4392937-8156-1102072095-ghost=cs.msu.su_at_[hidden]>
Envelope-to: ghost_at_[hidden]
Delivery-date: Fri, 03 Dec 2004 14:10:19 +0300
Received: from mail by zigzag.lvk.cs.msu.su with spam-scanned (Exim 3.36 #1 (Debian))
id 1CaBJY-0002Zx-00
for <ghost_at_[hidden]>; Fri, 03 Dec 2004 14:09:29 +0300
Received: from imap.cs.msu.su ([158.250.10.39])
by zigzag.lvk.cs.msu.su with esmtp (Exim 3.36 #1 (Debian))
id 1CaBId-0002Yu-00
for <ghost_at_[hidden]>; Fri, 03 Dec 2004 14:08:31 +0300
Received: from n18a.bulk.scd.yahoo.com (n18a.bulk.scd.yahoo.com [66.94.237.47])
by imap.cs.msu.su (8.12.11/8.12.11) with SMTP id iB3B8Mp9013970
for <ghost_at_[hidden]>; Fri, 3 Dec 2004 14:08:24 +0300 (MSK)
(envelope-from sentto-4392937-8156-1102072095-ghost=cs.msu.su_at_[hidden])
Received: from [66.218.69.4] by n18.bulk.scd.yahoo.com with NNFMP; 03 Dec 2004 11:08:15 -0000
Received: from [66.218.66.29] by mailer4.bulk.scd.yahoo.com with NNFMP; 03 Dec 2004 11:08:15 -0000
X-Yahoo-Newman-Property: groups-email
X-Sender: ghost_at_[hidden]
X-Apparently-To: jamboost_at_[hidden]
Received: (qmail 79295 invoked from network); 3 Dec 2004 11:08:14 -0000
Received: from unknown (66.218.66.172)
by m23.grp.scd.yahoo.com with QMQP; 3 Dec 2004 11:08:14 -0000
Received: from unknown (HELO zigzag.lvk.cs.msu.su) (158.250.17.23)
by mta4.grp.scd.yahoo.com with SMTP; 3 Dec 2004 11:08:14 -0000
Received: from zigzag.lvk.cs.msu.su ([158.250.17.23])
by zigzag.lvk.cs.msu.su with esmtp (Exim 3.36 #1 (Debian))
id 1CaBHW-0002Y1-00
for <jamboost_at_[hidden]>; Fri, 03 Dec 2004 14:07:22 +0300
To: jamboost_at_[hidden]
User-Agent: KMail/1.6.2
Message-Id: <200412031407.21951.ghost_at_[hidden]>
X-Scanner: exiscan *1CaBHW-0002Y1-00*aav3mina6mo*
X-eGroups-Remote-IP: 158.250.17.23
From: Vladimir Prus <ghost_at_[hidden]>
X-Yahoo-Profile: vladimir_prus
MIME-Version: 1.0
Mailing-List: list jamboost_at_[hidden]; contact jamboost-owner_at_[hidden]
Delivered-To: mailing list jamboost_at_[hidden]
Precedence: bulk
List-Unsubscribe: <mailto:jamboost-unsubscribe_at_[hidden]>
Date: Fri, 3 Dec 2004 14:07:21 +0300
Subject: [jamboost] print module fails unit test
Reply-To: jamboost_at_[hidden]
Content-Type: text/plain;
charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.80/614/Wed Dec 1 18:44:43 2004
clamav-milter version 0.80j
on imap.cs.msu.su
X-Virus-Status: Clean
X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on zigzag.lvk.cs.msu.su
X-Spam-Level: 
X-Spam-Status: No, hits=-4.7 required=7.0 tests=AWL,BAYES_00 autolearn=ham 
version=2.64
X-UID: 7521
X-Length: 3783

Rene,
I just got the following:

/home/ghost/Work/boost/tools/build/v2/util/print.jam:463: in __test__ from 
module __test-print__
error: assertion failure: [ escape-html "one two three" "&<>" ]
error: expected: "one&nbsp;two&nbsp;three" "&amp;&lt;&gt;"
error: got: "one two three" "&amp;&lt;&gt;"

This did not occur previously because this module was not unit-tested 
automatically. I'm not sure if this is a problem or not, but for now I've 
just disabled the test in question.

- Volodya

Yahoo! Groups Links

 --Boundary-00=_yEn2B8rnXPjBSR6--