Re: [jamboost] [BBv2] patch, review needed - msvc autodetection code

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-09-22 09:15:23

Hi Alexey,

> One more patch for review. This time it is autodetection code for the
> msvc toolset. 

Generally, the patch is fine. However some documentation is desired:

1. For large patches, it's preferrable to send proposed log message along with 
the patch. This allows to document the purpose (indent) of the patch.

2. I see you've dropped use of the VS80COMNTTOOLS variable, and also dropped
default paths for 8.0, 7.0 and 7.1. You left default paths for 6.0 and 
7.1toolkit. I'd like some comment explaining this. I assume the problem with 
7.1 toolkit is that it does not set any registry keys, but what's wrong with 
6.0. Does it have the same problem.

Also, will "using msvc ; " still work when I have nothing in registry, but 
cl.exe in in PATH?

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2