Re: [jamboost] Re: [BBv2] [msvc] patch - new configure rule + configure all syntax

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-09-22 09:04:16

On Thursday 22 September 2005 00:27, Alexey Pakhunov wrote:
> Alexey Pakhunov wrote:
> > The attached patch (msvc.diff) implements items 5 and 6 from the list
>
> Just found an error in the patch:
>
> # take the first detected version
> version = $($(.versions).all[1]) ;
>
> Should be:
>
> # take the first detected version
> version = [ $(.versions).all ] ;
> version = $(version[1]) ;

In the patch, I see this:

+ # Mark the configuration as 'used'.
+ if [ $(.versions).use $(version) ] 
+ {
+ options = [ $(.versions).get $(version) : options ] ;
+ 
+ # Generate condition and save it
+ local condition = [ common.check-init-parameters msvc : 
+ version $(v) ] ;

What does it mean for 'use' to return false? Should be emit an error or 
warning if it returns false?

Also, the patch does not apply cleanly for me, a pretty large block of changes
is rejected, both by "patch" and by emacs. Can you regenerate the diff against 
the current CVS state. And it would be better to use unified diff format 
('cvs diff -u'), not the context diff you're using.

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2