Re: [BBv2] patch, review needed - msvc autodetection code

From: Alexey Pakhunov (alexeypa_at_[hidden])
Date: 2005-09-26 15:46:55

Vladimir Prus wrote:
> Thanks. I have only one question about the patch. In 'configure-really', you 
> set "version" to "default" if it's not yet set. Later the "version" variable 
> is passed to "default-paths" rule. I don't see that "default-paths" rules 
> does any special handling for version="default"; it looks like nothing will 
> be returned, while it should return paths for all versions. Am I missing 
> something.

The 'configure-really' rule sets 'version' to 'default' only if the list 
of detected versions is empty. In this case 'default-paths' will not 
return any paths anyway.

But I noticed another problem: the condition is wrong when 'default' is 
passed and the list of detected versions is not empty. It will be 
'<toolset>msvc' while it should be '<toolset>msvc-version'. Otherwise it 
won't be possible to do this:

using msvc : default ;
using msvc : 7.1 ; // will fail in 'common.check-init-parameters'

I will send the fix shortly.

BTW I composed the table describing expected behavior depending on 
passed version, number of detected configurations and presence cl.exe in 
the path:

Not detected Detected Not detected/path Detected/path
default Error Use detected Create "default" Use detected
all None Use all None Use all
x.y - Use "x.y" - Use "x.y"
a.b Error Error Create "a.b" Create "a.b"

"Not detected" - no configurations were detected;
"Not detected/path" - no configurations were detected but 'cl.exe' is in 
the path;
"Detected" - the same as above but some configuration(s) were detected;
"x.y" - a detected version;
"a.b" - an undetected version.

I guess I will add it to msvc.jam comments. :-)

> Also, I suggest as part as some future patch you add your name to copyrights 
> in the file. You contributions are pretty large already.

OK. :@)

Best regards/Venlig hilsen,
Alexey Pakhunov.