Re: [jamboost] Re: [BBv2] patch, review needed - msvc autodetection code

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-09-26 01:03:45

Hi Alexey,

> > 2. I see you've dropped use of the VS80COMNTTOOLS variable, and also
> > dropped default paths for 8.0, 7.0 and 7.1. You left default paths for
> > 6.0 and 7.1toolkit. I'd like some comment explaining this. I assume the
> > problem with 7.1 toolkit is that it does not set any registry keys, but
> > what's wrong with 6.0. Does it have the same problem.
>
> We didn't have autodetection for 6.0 before and I didn't know where the
> installation path is stored in the registry. After some googling the
> correct path was found. It is
> "HKLM\SOFTWARE\Microsoft\VisualStudio\6.0\Setup\Microsoft Visual
> C++\ProductDir". At least some OpenOffice-related scripts relay on it.
>
> Free C++ Toolkit does not have registry settings at all. I added the
> comment.

Thanks. I have only one question about the patch. In 'configure-really', you 
set "version" to "default" if it's not yet set. Later the "version" variable 
is passed to "default-paths" rule. I don't see that "default-paths" rules 
does any special handling for version="default"; it looks like nothing will 
be returned, while it should return paths for all versions. Am I missing 
something.

I've applied the patch. I the above question will require any code changes 
that can be done later. 

Also, I suggest as part as some future patch you add your name to copyrights 
in the file. You contributions are pretty large already.

Thanks,
Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2