Re: [Boost-build] BBv2 msvc.jam: An attempt to reduce code duplication in actions

From: Andrei Melnikov (andy.melnikov_at_[hidden])
Date: 2006-06-26 06:18:03

On 25/06/06, Reece Dunn <msclrhd_at_[hidden]> wrote:
> Andrei Melnikov wrote:
> > Patch version 2.
> > - No cl.exe command line duplication any more, including compile.pch rule
> > - Whitespace cleanup: tab fix from my previous patch, some trailing
> > space removal
>
> One thing I have noticed with this patch: the build output results in things like:
>
> ...updating 3161 targets...
> cc-compile bin.v2\libs\date_time\build\msvc-7.1\debug\greg_month.obj
> greg_month.cpp
>
> so it might be better to name the action msvc.compile.cc to be consistent
> with the other toolsets. Apart from that, the patch is great :).
>
I don't know how to make it consistent, because the approach is
different. toolset.compile.* rules you see in other toolsets are
called by generators, and cc-compile rule is a "local" msvc rule
(marked with "local" keyword) called from those compile.* rules.

Moreover, you will see the same rule for .cpp, .c and .pch builds.

Maybe Vladimir will be able to tell what is better to do and how to
name these internal rules to make the diagnostic messages easier to
understand.

Andrei