Re: [Boost-build] Boost-1.36.0 FreeBSD patches for review

Subject: Re: [Boost-build] Boost-1.36.0 FreeBSD patches for review
From: Alexander Sack (pisymbol_at_[hidden])
Date: 2008-10-24 08:49:30

On Fri, Oct 24, 2008 at 3:25 AM, Steve M. Robbins <steve_at_[hidden]> wrote:
> On Thu, Oct 23, 2008 at 10:46:58PM -0400, Alexander Sack wrote:
>
>> In the meantime, I would like comments on the following three patches:
>>
>> - execution_monitor.ipp.patch
>>
>> I've ifdef'ed out the SIGNAL codes depending on the FreeBSD release as
>> well as define SIGPOLL as SIGIO (FreeBSD 7 and above fixes this).  I
>> made it several defines since different platforms might have some
>> support but not all (wasn't sure, I was gong for maximum flexibility
>> without being too #ifdef happy).
>
> I didn't look at your patch, but suggest instead the patch from
> trac ticket 2152 http://svn.boost.org/trac/boost/ticket/2152
> which does not require checking platform versions and is thus
> more portable.  (And which has been applied to trunk)

Steve that only applies to one signal code.  Are you saying to have my
patch be against trunk or that this patch fixes other issues?  The
diff on that incident will certainly still fail on FreeBSD 6.x and
below.  Please take a look at the patch and let me know.

-aps