|
Boost-Build : |
Subject: Re: [Boost-build] Boost-1.36.0 FreeBSD patches for review
From: Steve M. Robbins (steve_at_[hidden])
Date: 2008-10-24 03:25:09
On Thu, Oct 23, 2008 at 10:46:58PM -0400, Alexander Sack wrote:
> In the meantime, I would like comments on the following three patches:
>
> - execution_monitor.ipp.patch
>
> I've ifdef'ed out the SIGNAL codes depending on the FreeBSD release as
> well as define SIGPOLL as SIGIO (FreeBSD 7 and above fixes this). I
> made it several defines since different platforms might have some
> support but not all (wasn't sure, I was gong for maximum flexibility
> without being too #ifdef happy).
I didn't look at your patch, but suggest instead the patch from
trac ticket 2152 http://svn.boost.org/trac/boost/ticket/2152
which does not require checking platform versions and is thus
more portable. (And which has been applied to trunk)
Regards,
-Steve
Boost-Build list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk