Re: [Boost-build] [Boost-commit] svn:boost r75765 - trunk/tools/build/v2/engine

Subject: Re: [Boost-build] [Boost-commit] svn:boost r75765 - trunk/tools/build/v2/engine
From: Vladimir Prus (ghost_at_[hidden])
Date: 2011-12-01 16:45:40

On 01/12/11 23:34, steven_at_[hidden] wrote:
> Author: steven_watanabe
> Date: 2011-12-01 14:34:06 EST (Thu, 01 Dec 2011)
> New Revision: 75765
> URL: http://svn.boost.org/trac/boost/changeset/75765
>
> Log:
> Short circuit test if a file exists, when the name contains a grist.
> Text files modified:
>     trunk/tools/build/v2/engine/pathunix.c |    20 ++++++++++++++------
>     1 files changed, 14 insertions(+), 6 deletions(-)
>
> Modified: trunk/tools/build/v2/engine/pathunix.c
> ==============================================================================
> --- trunk/tools/build/v2/engine/pathunix.c	(original)
> +++ trunk/tools/build/v2/engine/pathunix.c	2011-12-01 14:34:06 EST (Thu, 01 Dec 2011)
> @@ -384,13 +384,21 @@
>
>   OBJECT * short_path_to_long_path( OBJECT * short_path )
>   {
> -    char buffer2[_MAX_PATH];
> -    int ret = ShortPathToLongPath( object_str( short_path ), buffer2, _MAX_PATH );
> -
> -    if (ret)
> -        return object_new( buffer2 );
> +    /* Short circuit names with grists. */
> +    if ( object_str( short_path )[ 0 ] == '<' )
> +    {
> +        return object_copy( short_path );
> +    }

Should we even be calling this on gristed paths?

Thanks,
Volodya