Re: [Boost-build] [Boost-commit] svn:boost r75765 - trunk/tools/build/v2/engine

Subject: Re: [Boost-build] [Boost-commit] svn:boost r75765 - trunk/tools/build/v2/engine
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2011-12-01 17:14:21

AMDG

On 12/01/2011 01:45 PM, Vladimir Prus wrote:
> On 01/12/11 23:34, steven_at_[hidden] wrote:
>> <snip>
>> --- trunk/tools/build/v2/engine/pathunix.c    (original)
>> +++ trunk/tools/build/v2/engine/pathunix.c    2011-12-01 14:34:06 EST
>> (Thu, 01 Dec 2011)
>> @@ -384,13 +384,21 @@
>>
>>   OBJECT * short_path_to_long_path( OBJECT * short_path )
>>   {
>> -    char buffer2[_MAX_PATH];
>> -    int ret = ShortPathToLongPath( object_str( short_path ), buffer2,
>> _MAX_PATH );
>> -
>> -    if (ret)
>> -        return object_new( buffer2 );
>> +    /* Short circuit names with grists. */
>> +    if ( object_str( short_path )[ 0 ] == '<' )
>> +    {
>> +        return object_copy( short_path );
>> +    }
> 
> Should we even be calling this on gristed paths?
> 

Probably not.  I'm not entirely sure that this
function has a good reason to exist at all, though.
I'm still trying to figure out the path-normalization
mess.  Sometime the paths are converted to lower case,
sometimes not.  Sometimes short_path_to_long_path
is called, sometimes not.

In Christ,
Steven Watanabe