Subject: Re: [Boost-build] Dependencies dropped during concurrent builds
From: Nogradi, Chris (Chris.Nogradi_at_[hidden])
Date: 2013-11-01 18:50:39
On Friday, November 01, 2013 4:04 PM, Steven Watanabe wrote:
> This patch should fix it. Are there any more problems?
Yes it does fix the issue. Thanks! I am trying a number of scenarios before I conclude that it is good. There are a couple other product builds that need to be tested also. I'll report what I find.
BTW, thanks for the performance improvements that you (and others) have made in the past year to bb, they have been substantial.
I do have a question regarding your enhancement to property.refine where you had removed some 'premature optimizations which hurt performance' in svn83854. Well I had made some changes to this rule to also remove sub-features of features that it had removed, otherwise the overridden feature would be removed but its sub-features would remain and clash with the sub-features specified in the requirements. But your change suggests that I should not be doing that here. Or should I? I was doing this before:
local required-value = $(__require__$(p:G)) ;
if $(p:G=) != $(required-value)
result += $(p:G)$(required-value) ;
result += $(p) ;
---> local subfeature = [ MATCH <(.*)-(.*):.*> : $(p:G) ] ;
---> local required-value = $(__require__<$(subfeature)>) ;
---> if ! $(required-value) || $(required-value) = $(subfeature)
result += $(p) ;
Also, your change makes a reasonable difference when high level targets have propagated requirements attached to them. Before the change, adding a propagated property to each dll (we can have up to 40) produced by our builds would add 1/2 second to the no-op build time (for a total of 20 seconds). But even after the change, in order to get good performance on incremental builds, I still had to put the propagated properties as close as possible to where they are needed. I am not sure I understand why they have such a large impact on the build. Can you comment? In my current state (being careful with propagated requirements), the change does save me 3 seconds on no-op builds.
CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be confidential and/or legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.
Boost-Build list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk