Re: Introducing generation of non-fixed size filters/kernels

From: Mateusz Loskot (mateusz_at_[hidden])
Date: 2019-07-12 17:34:36

On Fri, 12 Jul 2019 at 14:57, stefan <stefan_at_[hidden]> wrote:
> On 2019-07-12 4:58 a.m., Olzhas Zhumabek wrote:
> >
> > I can cherry pick commits into new branch, the problem is that the
> > changes are mixed with Harris corner detector code.
>
> Moving self-contained algorithms out of your current PR seems fine, in
> particular if they are accompanied by their own docs, tests, etc.

Yes, tests are a must to include, at least basic tests, for valid and
invalid input.

Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net