Re: [gsoc2020] Answer to histogram design questions from Slack

From: Pranam Lashkari (plashkari628_at_[hidden])
Date: 2020-06-05 03:37:34

On Thu, Jun 4, 2020 at 9:59 PM Mateusz Loskot <mateusz_at_[hidden]> wrote:

> On Sun, 31 May 2020 at 10:52, Pranam Lashkari <plashkari628_at_[hidden]>
> wrote:
> >
> > According to me, we should have our own container for the histogram. This
> > does not have to be much complicated or advanced as we are going to use
> > standard containers. I think we can use an implementation like we have
> for
> > the kernel.
>
> Can you drop what prototypes you have in mind?
>
> template <typename T, typename Allocator = std::allocator<T> >
> class histogram : public detail::histogram_adaptor<std::vector<T,
> Allocator>>
>
> template <typename T, std::size_t Size>
> class histogram_fixed : public detail::histogram_adaptor<std::array<T, 256>
>
> Anything else or different?
>

Yes, This is what I had in my mind, but since Debabrata mentioned on slack
that he wants to use the unordered map as an underlying container I am a
little confused. Debabrata would you like to throw some light on this!

-- 
Thank you,
Pranam Lashkari