Boost logo

Boost-Maint :

Subject: Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.
From: Ahmed Charles (acharles_at_[hidden])
Date: 2014-03-01 20:42:49


---------------------------------------- > From: acharles_at_[hidden] > To: boost-maint_at_[hidden] > Subject: RE: [Boost-maint] [dynamic_bitset] Fixes for various tickets. > Date: Thu, 27 Feb 2014 23:34:15 -0800 > > ---------------------------------------- >> From: mclow.lists_at_[hidden] >> Date: Thu, 27 Feb 2014 07:32:12 -0800 >> To: boost-maint_at_[hidden] >> Subject: Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets. >> >> >> On Feb 25, 2014, at 11:52 PM, Ahmed Charles <acharles_at_[hidden]> wrote: >> >> [ edited to show which pull request I’m talking about ] >>> https://github.com/boostorg/dynamic_bitset/pull/1 (I didn't do this one but I'm willing to push it through the process) >>> >>> The second fixes the following tickets: 2841, 5158 and 5159 >>> >>> Let me know if you have any comments. >> >> Tests? >> >> The fix for 5159 doesn’t appear to change any functionality, so I expect that the existing tests will catch this. >> I don’t see any tests at all for lowest_bit (#5158) or the hashing (#2841). >> >> Anyone else have comments? > > > Yes, these should have tests. I'll work on that. > > Any comments on the other pull request? :) I pushed 5159, which didn't require additional testing to develop. I'll add tests for the other two and submit another pull request/review.


Boost-Maint list run by bdawes at acm dot org