Re: [Boost-Users] AmigaOS port of Boost 1.27.0

From: Darin Adler (darin_at_[hidden])
Date: 2002-03-24 13:50:17

On Sunday, March 24, 2002, at 09:29 AM, Steven Solie wrote:

> I've started porting Boost 1.27.0 to AmigaOS for use in a project of
> mine and I have a few additions and diffs to contribute.  I've
> created a platform file so other AmigaOS users can at least start
> using the Boost out of the box.

That's great! I assume John Maddock will put these changes into 
boost/config, but I'm available to help if need be. I can probably deal 
with the missing assert includes.

> #define BOOST_DISABLE_THREADS

The BOOST_DISABLE_THREADS define shouldn't be set for a platform. If the 
platform doesn't have threads, we just don't define BOOST_HAS_THREADS 
for that platform. So you shouldn't need this line. If you do need it, 
can you explain why?

> #define BOOST_NO_CWCHAR
> #define BOOST_NO_CWCTYPE
> #define BOOST_NO_SWPRINTF

You only have to define BOOST_NO_CWCHAR. If it's defined, 
BOOST_NO_CWCTYPE and BOOST_NO_SWPRINTF are both defined for you by 
suffix.hpp. This should be in the documentation, but perhaps it's not.

> #define BOOST_NO_INTRINSIC_WCHAR_T

This is usually a property of the compiler, not the platform, and so 
it's the responsibility of the boost/config/compiler/xxx.hpp file to set 
this. But I see that you're using GCC 2.95.3. I think that GCC 2.95.3 
does have an intrinsic wchar_t. What's going on here.

> 3) libs/graph/test/isomorphism.cpp
>
> - inline bool verify_isomorphism(const Graph1& g1, const Graph2& g2,

I'm not sure why you removed this function template. It's used in 
test_isomorphism below. Could you elaborate?

> + #include <cassert>

Since <cassert> and <assert.h> are identical and some platforms lack 
<cassert> we might want to use <assert.h> here even though it's a 
deprecated feature.

     -- Darin