Re: [Boost-users] [Boost.Filesystem] Missing inline keywords inI18N branch

From: Beman Dawes (bdawes_at_[hidden])
Date: 2005-12-19 22:01:52

"Marc VIALA" <mviala_at_[hidden]> wrote in message 
news:200512190743.jBJ7hfWb031766_at_smtp5.clb.oleane.net...
>Hi,
>
>I've already sent this email but I've not seen any reply, maybe I've missed 
>it.

Sorry, I missed your original message.

>In order to take advantage of the I18N/HEAD CVS merging and after I've 
>checked that the "inline" declarations
> are always missed; I post again my corrections in "convenience.hpp" for 
> decode_system_message () declaration
>and "fstream.hpp" for narrow_path() declaration, see the attached files for 
>diff.
>
>Could you confirm these corrections?

I made the convenience.hpp correction in CVS as you indicated, and also for 
the other overload.

In fstream.hpp, narrow_path() is a larger function, and gets called a number 
of times. So the best fix to avoid ODR violations is, I think, to move the 
declaration to a library translation unit. I don't want to do that tonight - 
I'm tired and would mess it up.

Thanks for the report,

--Beman