Re: [Boost-users] [multi index] warning when used in copyconstructor: should be explicitly initialized

From: JOAQUIN LOPEZ MU?Z (joaquin_at_[hidden])
Date: 2007-02-26 16:42:40

----- Mensaje original -----
De: Christoph <christoph.duelli_at_[hidden]>
Fecha: Lunes, Febrero 26, 2007 9:54 pm
Asunto: Re: [Boost-users] [multi index] warning when used
in copy constructor: should be explicitly initialized
Para: boost-users_at_[hidden]

> Joaquín Mª López Muñoz wrote:
> 
> >> ----- Mensaje original -----
> >> Please try inserting the following before line 233 of
> >> the RC_1_34 version of multi_index_container.hpp:
> >>
> >>     bfm_header(),
> >>
> >> Warning gone? If so, I can commit this change in time
> >> for Boost 1.34.
> > 
> > Hello again, I've verified the patch locally and commited the
> > appropriate changes. I'd be so grateful if you could download
> > again a RC_1_34_0 snapshot from
> I have tried it.
> The snapshot works, my applying the the change myself did not.
> As I could not find a lot of other diffs in multi_index, I am
> somewhat baffled as to why.

Well, the same warning appeared at other places, so in the end
it was five different headers that I had to tweak.

> But the important thing is that the snapshot does work! Thank you.
> 
> 
> I am not sure if the following minor issue is still multi index's 
> fault. I get the following 'used uninitialized' warning for
> inf$side (which I did not get before):
[...]

You didn't get this before because the warned-about code is
new wrt to the Boost 1.33.1 version. Could you please try the
following: Replace lines 798-802 of ordered_index.hpp

  struct link_info
  {
    ordered_index_side       side;
    ordered_index_node_impl* pos;
  };

with

  struct link_info
  {
    link_info(){}

    ordered_index_side       side;
    ordered_index_node_impl* pos;
  };

Does this improve anything? BTW, the warning, again,
does not reflect any actual problem with the code :(

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo