Re: [Boost-users] [math] Warning in math/common_factor_rt.hpp

Subject: Re: [Boost-users] [math] Warning in math/common_factor_rt.hpp
From: Gabriel Redner (gredner_at_[hidden])
Date: 2010-07-01 14:05:11

Hi John,

Thanks for your reply.  My reading of the code is that it does indeed
work correctly if char is unsigned - it just ends up making some
comparisons which resolve to compile-time constants, which generates
warnings if GCC is given the right flags.  The patch you linked looks
like it should fix the problem, though I have not tested it.  In the
short term I am looking into removing the -funsigned-char flag from
our builds, since AFAICT it is not necessary.

Thanks again,
-Gabe