Subject: [ggl] Reviewing GGL against Boost requirements
From: Mateusz Loskot (mateusz)
Date: 2009-04-30 10:45:20
Bruno Lalande wrote:
> Hi Barend,
>> The CamelCase template parameters are fine for me.
>> Indentation makes it (my opinion) a bit less readable but is OK for me, I'll
>> get used to it.
> About this: I think the most disturbing source of unreadability once
> namespaces de-indented comes from namespaces such as "impl" that tend
> to pollute the files. In this case maybe we could isolate them in a
> "impl" directory when it's possible. If find my sources more readable
> when I do that with the "detail" namespaces. Don't know if it helps
> for the code you're reshaping...
I strongly agree.
Many of Boost libs put implementation details into detail namespace
with its components physically separated in dedicated directory,
unsurprisingly, called details ;-)
I practice it myself and I like it
>> What I really find hard is the 80 characters. Even if namespaces are not
>> I tried to adapt and nearly all lines get broken in the most weirdest
>> places, and/or spread over four lines. I just checked the Boost libraries
>> and all the libraries I checked (mpl, lambda, proto, variant, spirit) do NOT
>> follow it.
> Indeed some sources don't follow the rule, but much efforts are made
> to follow it if you look carefully. I think it can be broken but the
> writer has to keep this limit in mind in order to avoid running over
> it too much.
I agree. I don't mind extending 80 up to 100 but without forgetting
there is a limit, so 120 lines are forbidden.
> I'm OK to not be too strict about that, but let's at least stick to a
> 100-character rule.
...and not more.
-- Mateusz Loskot, http://mateusz.loskot.net
Geometry list run by mateusz at loskot.net