Geometry Boost List: Re: [geometry] io - WKB

Subject: Re: [geometry] io - WKB
From: Mats Taraldsvik (mats.taraldsvik_at_[hidden])
Date: 2013-09-02 14:19:09

Hi Mateusz,

On 08/30/2013 01:25 AM, Mateusz Loskot wrote:
> On 28 August 2013 20:52, Mats Taraldsvik <mats.taraldsvik_at_[hidden]> wrote:
>> On 08/28/2013 05:37 PM, Barend Gehrels wrote:
>> I have attached three patches, created from git using this recipe
>> http://codeprairie.net/blogs/chrisortman/archive/2008/01/14/creating-subversion-patches-with-git.aspx
>>
>> It would be great if you could review them.
> Mats,
>
> I updated your patches and submitted as ticket to Boost Trac
>
> https://svn.boost.org/trac/boost/ticket/9066
>
> where it has more convenient form for review:
>
> https://svn.boost.org/trac/boost/attachment/ticket/9066/Mats-Taraldsvik-MultiPoint-WKB.patch
>
> What I've done is:
>
> - translated your Git patches into SVN format
> - Applied your patches: patch  -p0 -i 000[1-3].patch
> - Added Jamfile.v2 files to enable building and running tests
> - svn diff > Mats-Taraldsvik-MultiPoint-WKB.patch
>
> It looks good, I haven't spotted any issues.
> Also, the read_wkb.cpp tests run and pass for me (Linux 64-bit, GCC 4.8.1).
>
> If no objections arrive, I can submit your patch to SVN trunk.

Thank you very much, I'll try to do this directly next time (and I'm 
looking forward to the boost git migration/modularisation)

By the way, I'm also running Linux 64-bit, although the GCC version is 
4.6.3.

If someone could look at the compile errors for the Linestring WKB test, 
and point to what is wrong / what needs implementing, I will try to add 
more tests.

>
> Thanks!
>
> Best regards,

Mats