Subject: Re: [geometry] io - WKB
From: Mats Taraldsvik (mats.taraldsvik_at_[hidden])
Date: 2013-09-02 14:19:09
On 08/30/2013 01:25 AM, Mateusz Loskot wrote:
> On 28 August 2013 20:52, Mats Taraldsvik <mats.taraldsvik_at_[hidden]> wrote:
>> On 08/28/2013 05:37 PM, Barend Gehrels wrote:
>> I have attached three patches, created from git using this recipe
>> It would be great if you could review them.
> I updated your patches and submitted as ticket to Boost Trac
> where it has more convenient form for review:
> What I've done is:
> - translated your Git patches into SVN format
> - Applied your patches: patch -p0 -i 000[1-3].patch
> - Added Jamfile.v2 files to enable building and running tests
> - svn diff > Mats-Taraldsvik-MultiPoint-WKB.patch
> It looks good, I haven't spotted any issues.
> Also, the read_wkb.cpp tests run and pass for me (Linux 64-bit, GCC 4.8.1).
> If no objections arrive, I can submit your patch to SVN trunk.
Thank you very much, I'll try to do this directly next time (and I'm
looking forward to the boost git migration/modularisation)
By the way, I'm also running Linux 64-bit, although the GCC version is
If someone could look at the compile errors for the Linestring WKB test,
and point to what is wrong / what needs implementing, I will try to add
> Best regards,
Geometry list run by mateusz at loskot.net