Geometry Boost List: Re: [geometry] distance contribution merge request

Subject: Re: [geometry] distance contribution merge request
From: Menelaos Karavelas (menelaos.karavelas_at_[hidden])
Date: 2014-05-14 08:27:44

Hi Samuel.

On 14/05/2014 03:24 μμ, Samuel Debionne wrote:
> Hello,
>
> My take is that it's better to merge Menelaos contribution first since
> it's more mature. As said on GitHub my PR needs to be reworked since I
> uncovered some problems when adding the tests.

FYI, the distance code has just been merged (a few minutes ago).
It might be a good idea to try and build on top of that to avoid conflicts.
Let me know if you need any help in figuring out things that have changed.

> I have already reworked the code locally to take your inputs into
> account. I will let let you known when it's ready for review by Bruno
> (hopefully before the end of the week).

Good. Looking forward to it.

- m.

> Anyway I agree with Menelaos in that both PR should be quite orthogonal
> so only minor conflicts are to be expected.
>
> Samuel
>
>
> Le 12/05/2014 21:31, Barend Gehrels a écrit :
>> hi,
>>
>> We received a merge request from Samuel Debionne for support of variants
>> for the distance algorithm. Thanks very much for this.
>>
>> Menelaos, how can that be combined with your work for distance
>> algorithm? Can it be merged, and which should go first?
>>
>> Bruno, can you take a look at the contribution? (Others are of course
>> welcome too).
>>
>> This is the info:
>>
>> Or view, comment on, or merge it at:
>>
>>    https://github.com/boostorg/geometry/pull/26
>>
>>
>>          Commit Summary
>>
>>    * [distance] Add variant support
>>
>>
>>          File Changes
>>
>>    * *M* include/boost/geometry/algorithms/distance.hpp
>>      <https://github.com/boostorg/geometry/pull/26/files#diff-0> (277)
>>
>>
>>          Patch Links:
>>
>>    * https://github.com/boostorg/geometry/pull/26.patch
>>    * https://github.com/boostorg/geometry/pull/26.diff
>>
>>
>> Regards, Barend
>>
>>
>>
>> _______________________________________________
>> Geometry mailing list
>> Geometry_at_[hidden]
>> http://lists.boost.org/mailman/listinfo.cgi/geometry
>>
> _______________________________________________
> Geometry mailing list
> Geometry_at_[hidden]
> http://lists.boost.org/mailman/listinfo.cgi/geometry