Geometry Boost List: Re: [geometry] Result change in geometry::centroid between version 1.53 and 1.58

Subject: Re: [geometry] Result change in geometry::centroid between version 1.53 and 1.58
From: eric.noirfalise_at_[hidden]
Date: 2015-04-27 04:58:02

Eric.noirfalise wrote:

> Selon Adam Wulkiewicz <[hidden email]>:
>
>> Eric.noirfalise wrote:
>>> Hi Adam,
>>>
>>> Done for ticket : https://svn.boost.org/trac/boost/ticket/11236
>> Thanks!
>>
>> Actually it's a manifestation of a different bug, in arithmetic
>> functions, in this particular case in add_point().
>> See: https://github.com/boostorg/geometry/pull/283
>>
>> You wrote in a ticket that the compiler reports a warning.
>> Could you paste it here or there?
... [show rest of quote]
<snip>
> Here is the (awful) cascaded warning stack under visual studio 2012 :
>
>
1>C:\dev\Externals\Package\boost\boost_1_58_0\include\boost/geometry/arithmetic/arithmetic.hpp(75):
> warning C4244: 'argument' : conversion from 'double' to 'const int', possible
> loss of data
>

Ok, so after the fix is applied you shouldn't see this warning.
Could you verify that it works for you?
E.g. grab this file
https://github.com/awulkiew/geometry/blob/42d56f6116659336551e0b85a6a68dd908379923/include/boost/geometry/arithmetic/arithmetic.hpp
and simply replace in your copy of Boost 1.58.

Regards,
Adam
_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry

Hi Adam,

Your patch seems great :
- no more warning under Visual studio 2012.
- corrected result in my case

Thank you very much,
Regards,
Eric Noirfalise