Re: [boost] Patches for unversioned MSVC checks

From: Phil Nash (phil.nash.lists_at_[hidden])
Date: 2002-07-13 10:25:54

Shouldn't these things go in the config files as macros for each compiler
dependant feature, rather than compiler conditionals being exposed in the
program code?
This way the features in question only need to be updated in one place. At
least that's my understanding of it. I'm not saying *you* should have to do
this, David, I'm just wondering why we have this problem in the first place
since we seem to have a pretty good way of dealing with exactly this
complexity already.

Regards,

[)o
IhIL..

----- Original Message -----
From: "David Abrahams" <david.abrahams_at_[hidden]>
To: "boost" <boost_at_[hidden]>
Sent: Saturday, July 13, 2002 1:37 PM
Subject: [boost] Patches for unversioned MSVC checks

>

----------------------------------------------------------------------------
----
> I've taken the liberty of committing fixes for *some* of boost's
BOOST_MSVC
> checks which weren't checking the version number. I took a somewhat
> conservative route, which also means it's somewhat ham-fisted -- in many
> cases the original test was written with MSVC6 in mind, and I just assumed
> that the same workaround would be needed for MSVC7 but not for later
> compilers. Hopefully, the enclosed list will be enough to prompt authors
> and maintainers to look over the changes and tune them appropriately.
>
> Note: in case it wasn't clear:  I DID NOT TRY TO FIX EVERYTHING. In
> particular, I gave up quickly on the graph library examples directory
> because it was too big and I didn't touch regex at all for lack of
> expertise. For other libraries I only made a change where the answer
seemed
> obvious to me. I double-checked my work, and I hope I didn't break
> anything. No guarantees of course.
>
> -Dave
>
> P.S. I am certain that we have lots of similar issues with __BORLANDC__
and
> __MWERKS__, probably others as well.
>
>
> +---------------------------------------------------------------+
>                   David Abrahams
>       C++ Booster (http://www.boost.org)               O__  ==
>       Pythonista (http://www.python.org)              c/ /'_ ==
>   resume: http://users.rcn.com/abrahams/resume.html  (*) \(*) ==
>           email: david.abrahams_at_[hidden]
> +---------------------------------------------------------------+
>
----------------------------------------------------------------------------
----
> _______________________________________________
> Unsubscribe & other changes:
http://lists.boost.org/mailman/listinfo.cgi/boost
>