RE: [boost] Formal Review for Boost I/O Library

From: Paul A. Bristow (boost_at_[hidden])
Date: 2003-03-03 18:50:11

I vote for acceptance of this package (from reading the documentation and
glancing at the code and examples - which could be more commented?).

I noted two tiny mistakes in the documentation streambuf_wrapping.html

in

Rationale
... is defined with the appropiate <<< mis-spelt

appropriate

..accessing that stream buffer, and checking if that stream didn't switch to an
external stream buffer.

'if that' doesn't make sense.  'if' or 'that'?

(You might also like to consider adding the following

        // Usage:  out << automatic ... << noadjust
        using std::ios_base;

        inline ios_base& __cdecl automatic(ios_base& _I)
        {_I.unsetf(ios_base::floatfield); // Neither fixed nor scientific.
        return (_I);  // This is the default.
        }

        inline ios_base& __cdecl noadjust(ios_base& _I)
        {_I.unsetf(ios_base::adjustfield); // Neither left, right nor internal.
        return (_I); // This is the default.
        }

two helpful manipulators which are needed to avoid using 'unsetf' a less
familiar feature that naive users should not need to know about to get back to
the default floating point layout.

Paul

Paul A Bristow, Prizet Farmhouse, Kendal, Cumbria, LA8 8AB  UK
[phone]   Mobile [phone]
Mobile mailto:pabristow_at_[hidden]
mailto:pbristow_at_[hidden]

> -----Original Message-----
> From: boost-bounces_at_[hidden]
> [mailto:boost-bounces_at_[hidden]]On Behalf Of Ed Brey
> Sent: Thursday, February 27, 2003 5:00 AM
> To: boost_at_[hidden]
> Subject: [boost] Formal Review for Boost I/O Library
>