RE: [boost] Re: RC_1_30_0 still broken (apologies and help!)

From: Aleksey Gurtovoy (agurtovoy_at_[hidden])
Date: 2003-03-16 21:08:31

Andreas Huber wrote:
> Beman & John,
> 
> > Both the main trunk and RC_1_30_0 are working fine for me 
> as of Sunday 6PM
> > US Eastern time.
> 
> Douglas Gregor has already fixed the is_class.hpp problem, please see
> 
> http://lists.boost.org/MailArchives/boost/msg45230.php

That's not the problem that caused the failures Ralf reported; it's the
addition of the line "::boost::type_traits::ice_not<
::boost::is_function<T>::value >::value" itself, not the missing comma, that
is wrong and needs to be reverted. 

> 
> > Today's Win32 RC_1_30_0 regression tests (just posted) are 
> > showing new fails for VC++ 6 and VC++ 7 on is_polymorphic_test 
> > and is_reference_test.
> > Are these related to the is_class problem?
> 
> I don't think so, is_class.hpp is working just fine for me 
> now with CVS state from 2 hours ago...

I don't see how can it. That's what I get when I compile 'is_class_test.cpp'
on MSVC 6.5 (expectedly):

Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8804 for 80x86
Copyright (C) Microsoft Corp 1984-1998. All rights reserved.

is_class_test.cpp
F:\cvs_RC_1_30_0\boost\boost/type_traits/is_function.hpp(68) : error C2528:
'<Unknown>' : pointer to reference is illegal
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_function.hpp(79) : see
reference to class template instantiation
'boost::detail::is_function_impl<int &>' being compiled
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_class.hpp(67) : see
reference to class template instantiation 'boost::is_function<int &>' being
compiled
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_class.hpp(82) : see
reference to class template instantiation 'boost::detail::is_class_impl<int
&>' being compiled
        F:\cvs_RC_1_30_0\boost\libs\type_traits\test\is_class_test.cpp(19) :
see reference to class template instantiation 'boost::is_class<int &>' being
compiled
F:\cvs_RC_1_30_0\boost\boost/type_traits/is_function.hpp(68) : error C2528:
'<Unknown>' : pointer to reference is illegal
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_function.hpp(79) : see
reference to class template instantiation
'boost::detail::is_function_impl<struct UDT &>' being compiled
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_class.hpp(67) : see
reference to class template instantiation 'boost::is_function<struct UDT &>'
being compiled
        F:\cvs_RC_1_30_0\boost\boost/type_traits/is_class.hpp(82) : see
reference to class template instantiation
'boost::detail::is_class_impl<struct UDT &>' being compiled
        F:\cvs_RC_1_30_0\boost\libs\type_traits\test\is_class_test.cpp(38) :
see reference to class template instantiation 'boost::is_class<struct UDT
&>' being compiled

I am going revert 'is_class.hpp' to the 1.5 revision.

Aleksey