Re: [boost] Re: RC_1_30_0 still broken -- More lexical_cast

From: David Abrahams (dave_at_[hidden])
Date: 2003-03-18 16:54:46

Terje Slettebø <tslettebo_at_[hidden]> writes:

> Also these three tests, like MSVC 6, concerns tests where it doesn't throw
> when it's supposed to:
>
> BOOST_CHECK_THROW(lexical_cast<int>(" 123"), boost::bad_lexical_cast);
> BOOST_CHECK_THROW(lexical_cast<int>(std::string(" 123")),
> boost::bad_lexical_cast);
> BOOST_CHECK_THROW(lexical_cast<bool>(123), boost::bad_lexical_cast);
>
> If these are omitted for g++ 2.95.x, all tests pass for that compiler.
> However, as it compiles without errors on both MSVC 6 and g++ 2.95.x, maybe
> one shouldn't have any BOOST_WORKAROUND's in the test code?
>
> That will make it show up as failing on MSVC 6 and g++ 2.95.x, even though
> it passes almost all the enabled tests on both.

Often the cure is to break the test into two parts, so that you can
demonstrate passing the majority of tests even on broken compilers.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com