Boost logo

Boost :

From: Terje Slettebø (tslettebo_at_[hidden])
Date: 2003-03-18 16:42:38


>From: "David Abrahams" <dave_at_[hidden]>

> Terje Slettebø <tslettebo_at_[hidden]> writes:
>
> > - With wide character support in lexical_cast enabled for MSVC 6, three
> > tests (of 137) fail. These are omitted for that compiler version, using
> > BOOST_WORKAROUND and BOOST_TESTED_AT.
>
> You shouldn't be using BOOST_TESTED_AT for that compiler, since there
> are known newer versions
>
> BOOST_WORKAROUND(BOOST_MSVC, <= 1200)
>
> is the right test.

Right. Reading the docs in workaround.hpp, again, I see that now. I'll
change it.

> (unless of course it fails for those too).

No, it passes all tests on MSVC 7.

Also, I've just now got a mail from Gennaro Prota. He has tested the posted
version on g++ 2.95.3-10 (Cygwin). The test correctly disable wide character
support, and passed except for three cases:

lexical_cast_test.cpp(105): error in "test_conversion_to_intr": exception
boost::bad_lexical_cast is expected
lexical_cast_test.cpp(111): error in "test_conversion_to_intr": exception
boost::bad_lexical_cast is expected
lexical_cast_test.cpp(147): error in "test_conversion_to_boolle": exception
boost::bad_lexical_cast is expected

Notice the weird misspellings in the error messages. :)

Also these three tests, like MSVC 6, concerns tests where it doesn't throw
when it's supposed to:

BOOST_CHECK_THROW(lexical_cast<int>(" 123"), boost::bad_lexical_cast);
BOOST_CHECK_THROW(lexical_cast<int>(std::string(" 123")),
boost::bad_lexical_cast);
BOOST_CHECK_THROW(lexical_cast<bool>(123), boost::bad_lexical_cast);

If these are omitted for g++ 2.95.x, all tests pass for that compiler.
However, as it compiles without errors on both MSVC 6 and g++ 2.95.x, maybe
one shouldn't have any BOOST_WORKAROUND's in the test code?

That will make it show up as failing on MSVC 6 and g++ 2.95.x, even though
it passes almost all the enabled tests on both.

Regards,

Terje


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk