Re: [boost] Re: RC_1_30_0 still broken -- More lexical_cast

From: Beman Dawes (bdawes_at_[hidden])
Date: 2003-03-18 17:26:12

At 04:42 PM 3/18/2003, Terje Slettebø wrote:

 >BOOST_CHECK_THROW(lexical_cast<int>(" 123"), boost::bad_lexical_cast);
 >BOOST_CHECK_THROW(lexical_cast<int>(std::string(" 123")),
 >boost::bad_lexical_cast);
 >BOOST_CHECK_THROW(lexical_cast<bool>(123), boost::bad_lexical_cast);
 >
 >If these are omitted for g++ 2.95.x, all tests pass for that compiler.
 >However, as it compiles without errors on both MSVC 6 and g++ 2.95.x, 
maybe
 >one shouldn't have any BOOST_WORKAROUND's in the test code?
 >
 >That will make it show up as failing on MSVC 6 and g++ 2.95.x, even 
though
 >it passes almost all the enabled tests on both.

Remember that a lot of the concern isn't over the lexical_cast_test itself, 
but over date-time and other libraries which include lexical_cast.hpp, but 
don't use any of the wide-char facilities.

Even if lexical_cast_test is failing, the fixes will be a success if 
date-time tests no longer get compile errors.

If Dave hasn't beaten you to it, please go ahead and commit the changes so 
the regression tests can report on them overnight.

Thanks,

--Beman