[boost] Re: [type traits] is_abstract_class submission

From: Giovanni Bajo (giovannibajo_at_[hidden])
Date: 2004-01-13 14:44:45

John Maddock wrote:

> Is that OK?
>
> There are no workarounds for broken compilers (I don't know what they
> should be yet).

There is one needed workaround for the current version of GCC 3.4.0, see the
attacched patch. This will probably be fixed before the release, but anyway.
OK to commit it?

Index: is_abstract.hpp
===================================================================
RCS file: /cvsroot/boost/boost/boost/type_traits/is_abstract.hpp,v
retrieving revision 1.2
diff -u -w -b -r1.2 is_abstract.hpp
--- is_abstract.hpp 13 Jan 2004 19:04:15 -0000 1.2
+++ is_abstract.hpp 13 Jan 2004 19:44:01 -0000
@@ -67,7 +67,7 @@

    // GCC2 won't even parse this template if we embed the computation
    // of s1 in the computation of value.
-   BOOST_STATIC_CONSTANT(unsigned, s1 = sizeof(check<T>(0)));
+   BOOST_STATIC_CONSTANT(unsigned, s1 = sizeof(is_abstract_imp::template
check<T>(0)));

    BOOST_STATIC_CONSTANT(bool, value =
       (::boost::type_traits::ice_and<

-- 
Giovanni Bajo