[boost] Re: [serialization] CW problems...

From: David Abrahams (dave_at_[hidden])
Date: 2004-07-18 21:47:49

"Robert Ramey" <ramey_at_[hidden]> writes:

> Dave Abrahams wrote:
>
>>Rene Rivera <grafik.list_at_[hidden]> writes:
>
>>> boost-root/boost/utf8_codecvt_facet.hpp is original.
>>> boost-root/boost/program_options/utf8_codecvt_facet.hpp + *.cpp
>>> is slightly modified copy.
>>> Intention is that utf8_codecvt_facet will become standalone library
>>> at some time and these files will be replaced.
>>
>> Then it should be moved to boost.detail, directory and namespace.
>
>>Right.  We should never knowingly allow (near) duplicate code in the
>>repository.
>
> I don't think anyone did it knowingly.

I don't see how it could happen without explicit knowledge (?)

> Something like this should really be subjected to a mini-review and
> have its own separate test and documentation and reside outside any
> of the systems that use it.  

That's what the detail namespace/directory is for.  You only need to do a
mini-review if you want to make it a public facility in the library
that can be used by anyone who downloads it.  This is a long-standing
practice at Boost.

> This has been mentioned before by various people.  

So?

> I included Ron Garcia's version in the serialization project because
> I needed it.  I added a test and found that as one moves to other
> compilers and standard libraries little things keep popping up.
> E.G. gcc standard library defines wchar_t as 4 byte while others use
> 2.  So the status is "good enough for the serialization library"
>
> The serialization review specifically invited reviewers to critique
> this and no objections were raised that I recall.  There have been
> proposals for an improved version. My response is that I'm glad to
> use one that gets reviewed and accepted rather than the one we have
> now.  But so far nothing else has been submitted.

Please just move it to detail as Rene suggested.  We can do a
mini-review if anyone feels motivated enough to make it into a public
library.

-- 
Dave Abrahams
Boost Consulting
http://www.boost-consulting.com