Re: [boost] Re: Logging Library -- Formal Review Request

From: John Torjo (john.lists_at_[hidden])
Date: 2005-05-19 11:49:40

Hi Matt,

Many thanks for the review!

> 
> It would be nice to have it automatically rename or append to the old 
> log file instead of just replacing it, IMO.
> 
> - No log rotation.  This library does not support log rotation (at least 
> in the version I tried).  I didn't need this feature for my project, but 
> I'm sure it will be a frequently requested feature.

Yes, I will do it. I like log rotation myself ;)

> 
> * Do you think the library should be accepted as a Boost library?
> 
> Yes, but I suggest the author adds log rotation, because it is a feature 
> lots of people need.
> 

Yup, consider it done ;)

Best,
John

-- 
John Torjo,    Contributing editor, C/C++ Users Journal
-- "Win32 GUI Generics" -- generics & GUI do mix, after all
-- http://www.torjo.com/win32gui/ -v1.6.3 (Resource Splitter)
-- http://www.torjo.com/cb/ - Click, Build, Run!