Re: [boost] MS compiler detection

From: Ulrich Eckhardt (uli_at_[hidden])
Date: 2005-07-11 17:24:30

On Monday 11 July 2005 23:00, Rob Stewart wrote:
> From: Ulrich Eckhardt <uli_at_[hidden]>
>
> > MSC_VER <= 1200  ->  MSC_VER < 1300
> > MSC_VER > 1200  ->  MSC_VER >= 1300
> > MSC_VER == 1200  ->  MSC_VER < 1300
>
> I have no idea if this is important, but the last one clearly
> stands out.  Is it intentional that all versions less than 1300
> should match for those previous cases in which exactly version
> 1200 was to match?  IOW, should the last case be the following?
>
>    _MSC_VER >= 1200 && _MSC_VER < 1300

Yes, as someone already said, cl.exe v11.xx aka VC5 or before are so far away 
from C++ to be unsupported by boost anyway.

> As I typed that, I recall having read that "MSC_VER" was supposed
> to have been "_MSC_VER."  Did you miss that in your patch?

No. It's also missing the BOOST_WORKAROUND() or #ifdef or whatever, this is 
only pseudocode. To be honest, I didn't take the pointing out of this as a 
serious comment, as such an error in real code is far too quickly revealed by 
the compiler.

Uli