Re: [boost] [Review] The review of the Boost.Logging library starts today, November 7th

From: John Torjo (john.lists_at_[hidden])
Date: 2005-11-11 07:35:37

> 
> Before I start, I'm very happy that this library is being considered for
> inclusion in Boost - I've been using it for some time now, and overall
> I have been very happy with it.

Thanks ;)
> 
> 
> - What is your evaluation of the design?
> 
> I like the design. The concepts are very well thought out.
> 
> My only stumbling block has been that the default log manager can
> only be extended in an all-or-nothing fashion, which makes
> extending the logging solution quite difficult.
> 
> I would really like to have the option to simply replace the stream
> type in the default log manager, instead of the whole thing. This
> would make structured logging trivial.

Added to my TODO list :)

> 
> - What is your evaluation of the documentation?
> 
> The documentation lacks any rationale for the decisions made, and
> while it provides sufficient information for somebody who wants to
> use the default facilities (perhaps with a custom appender or two),
> I feel that the documentation could be improved by:
> 
>  - a high level, conceptual, overview of the library and the
>    facilities it provides
>  - adding rationale for design decisions
>  - more information on extending the library, possibly with
>    examples - I found myself guessing far too much.
> 

Yes, after the review, I want to do the docs in doxygen.

> I also felt that more advanced examples (and tests!) would have been
> useful when starting out with the library.

Noted.

> 
> - Are you knowledgeable about the problem domain?
> 
> Only insofar as I am aware of the problems of our existing logging
> systems at work, and how this solution addresses those areas.
> 
> 
> I feel that this library should be accepted into Boost, but that
> attention should be paid to the areas above (particularly the
> documentation for extenders).

Thanks, and will do!

Best,
John

-- 
John Torjo,    Contributing editor, C/C++ Users Journal
-- "Win32 GUI Generics" -- generics & GUI do mix, after all
-- http://www.torjo.com/win32gui/surfaces.html - Sky's the limit!
-- http://www.torjo.com/cb/ - Click, Build, Run!