Re: [boost] [shared_ptr] Was: Some notes on TR1 tests

From: Peter Dimov (pdimov_at_[hidden])
Date: 2005-11-11 07:51:35

Peter Dimov wrote:
> John Maddock wrote:
>>>>>> and see if this fixes the problem?
>>>>> 
>>>>> Which #include?
>>>> 
>>>>>>                 from
>>>>>> /u/troy/boost-regressions/boost/boost/detail/sp_counted_impl.hpp:34,
>>>> 
>>>> _This_ #include.
>>> 
>>> BTW: I can't reproduce the problem here, but my Cygwin g++ is a bit
>>> old (3.4).
>> 
>> No that doesn't make any difference (I see the same errors):
> 
> That's unpossible :-) since sp_counted_impl.hpp no longer includes
> <memory>. Can you please post the new error?

Never mind, I finally got it to fail. I had to #define TEST_STD_HEADERS.

>> in order
>> to make that fix work, you would have to stop shared_ptr.hpp
>> weak_ptr.hpp and *all their dependents* from including <memory>.
> 
> No, I don't. :-)

This is what needs to be done:

In shared_ptr.hpp, move #include <memory> to the top.

In weak_ptr.hpp, add

#include <memory>
#include <boost/detail/shared_count.hpp>

above

#include <boost/shared_ptr.hpp>.

I'll commit these fixes when the CVS starts working again.