Subject: Re: [boost] [mpl] mpl::string, help needed (vacpp, sun, borland)
From: Dmitry Goncharov (dgoncharov_at_[hidden])
Date: 2009-04-21 04:05:25
Eric Niebler wrote:
> (Sorry for the delayed response. I've been away.)
> Dmitry Goncharov wrote:
>> I ported mpl::string to sun c++ 5.9 (sunos_sparc) and made sure all
>> tests in libs/mpl/test/string.cpp pass.
>> Also verified that gcc-4.3.3 passes all tests on linux with the patch
>> Please, find the patch in the attachment.
> Terrific, thanks. A few observations ... your change to
> libs/mpl/test/string.cpp looks spurious. Can you comment?
The patch uses mpl::empty in order to implement push_front. So, it is a
good idea to test mpl::empty on mpl::string before testing push_front.
> Also, your change to string.hpp causes extra template instantiations
> for all platforms, instead of just for sun where it's needed. Can you
> put your change under a #ifdef BOOST_WORKAROUND? That would be ideal.
> (Also, using BOOST_WORKAROUND helps compiler devs find their bugs, but
> an even better way is to file them directly if you know how.)
I'll send a new patch a bit later.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk