Subject: Re: [boost] [property_tree] Files with tab and min/max issues
From: Sebastian Redl (sebastian.redl_at_[hidden])
Date: 2009-05-21 10:34:00
Jeremiah Willcock wrote:
> (reposting this because it was part of a previous thread that
> property_tree maintainers may not have been following)
True, thank you.
> Is libs/property_tree/detail/pugxml.hpp third-party code? It has
> several min/max and tab issues, but I did not fix them because it
> appeared to be outside code that we should not change. Should I fix
> the issues anyway?
You can, if you want to silence the warnings. In the long run, I plan to
remove this file anyway.
> Also, the following two files had tabs within test input strings. I
> do not know if they were intentional. If so, I should probably change
> them to \t, and if not, they should become spaces. What do you want
> me to do with them?
Either way is good. I think converting them to spaces retains at least
some readability of the files in question. I can add tabs to a small
test XML snippet to ensure the parser accepts them later.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk