Re: [boost] [property_tree] Files with tab and min/max issues

Subject: Re: [boost] [property_tree] Files with tab and min/max issues
From: Jeremiah Willcock (jewillco_at_[hidden])
Date: 2009-05-21 10:40:07

On Thu, 21 May 2009, Sebastian Redl wrote:

(snip)

>> Is libs/property_tree/detail/pugxml.hpp third-party code?  It has
>> several min/max and tab issues, but I did not fix them because it
>> appeared to be outside code that we should not change.  Should I fix
>> the issues anyway?
> You can, if you want to silence the warnings. In the long run, I plan to
> remove this file anyway.

I fixed the issues by changing to (std::min) and (std::max), and fixed the 
tab problem.

>> Also, the following two files had tabs within test input strings.  I
>> do not know if they were intentional.  If so, I should probably change
>> them to \t, and if not, they should become spaces.  What do you want
>> me to do with them?
> Either way is good. I think converting them to spaces retains at least
> some readability of the files in question. I can add tabs to a small
> test XML snippet to ensure the parser accepts them later.

I changed these files to spaces only.

-- Jeremiah Willcock