Re: [boost] sorting library proposal (Was: Review Wizard Status Report for June 2009)o

Subject: Re: [boost] sorting library proposal (Was: Review Wizard Status Report for June 2009)o
From: DE (satan66613_at_[hidden])
Date: 2009-08-19 14:26:49

on 19.08.2009 at 16:40
 Steven Ross wrote :
> I've added a "spirit-nav" bar at the top and bottom, just like in some other
> Boost documentation (and reuploaded).  I think that's what you were looking
> for.  It has home and up links that go back to the index page, and next and
> previous links that enable sequential scrolling through the docs.
much better

> I don't see how it hurts, so I implemented your suggestion; the constants
> are now defined as enum { val = # }, instead of having a type.  Thanks for
> your feedback.
well actually i meant that you can define all constants in one unnamed
enum like

    enum {
        MAX_SPLITS = 11,
        MAX_FINISHING_SPLITS = MAX_SPLITS + 1,
        LOG_MEAN_BIN_SIZE = 2,
        LOG_MIN_SPLIT_COUNT = 9,
        LOG_FINISHING_COUNT = 31,
        FLOAT_LOG_MEAN_BIN_SIZE = 2,
        FLOAT_LOG_MIN_SPLIT_COUNT = 8,
        FLOAT_LOG_FINISHING_COUNT = 4,
        MIN_SORT_SIZE = 3000
    };

additionally since you introduce them through a header, it's guaranteed
that they will not be presented in object code as separate entities
(contrast to 'static const int' or whatever)
    
-- 
Pavel