Subject: Re: [boost] Official warnings policy?
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-09 09:36:32
Patrick Horgan wrote:
> Phil Richards wrote:
> > On Thu, 2009-11-05 at 20:03 -0800, Steven Watanabe wrote:
> > > I've attached a patch that uses #pragma GCC system_header
> > From my understanding of this pragma, it turns off all
> > warnings from the header. Maybe I'm being incredibly
> > dumb, but isn't this a rather shotgun approach to the
> > problem? What if, by some chance, the header is
> > edited at some later stage and an issue is introduced
> > that would have generated (valid) warnings?
> Problem easily solved. In boost test builds using gcc use
> -Wsystem-headers to turn the warnings back on.
That's too broad in effect. It would enable warnings in headers that one doesn't want to hear from including, I suspect, those provided by the platform.
The best approach likely is a library specific mechanism that, by default, honors a Boost-wide config to disable warnings using #pragma GCC system_header. Then, all Boost libraries could disable the pragmas, when the Boost-wide configuration is adjusted, revealing warnings otherwise suppressed. Furthermore, individual libraries could be configured to ignore the Boost-wide setting to prevent the suppression of warnings in just that library, while the rest of Boost continues to suppress warnings.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.