Subject: Re: [boost] [gsoc] Boost.Process done
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-09-05 21:07:26
Boris Schaeling wrote:
> * The delegates in the context class expect this signature:
> std::pair<handle, handle> (bool). There is a parameter of
> type bool passed to indicate whether an input or an output
> stream is configured. Now it's not required anymore to pass a
> parameter like input_stream or output_stream yourself.
Why is true input and false ouput (or the reverse)? Use an enumerated type for clarity.
> * this signature: std::pair<handle, handle> (bool). Shall we
> use std::pair<handle, handle> to return two handles for the
> child and parent process or a struct with member variables
> called parent_end and child_end?
A child naturally ensues from a parent, so the order parent then child is easily remembered, though there is no harm in creating a struct that makes the members explicit.
> Shall we use a bool to indicate whether an input or output
> stream is configured or something else like an enumeration? I
> think it all depends on how many developers want to define
> new stream behaviors and if it's worth to make the signature
> a bit more self-explanatory?
bool is never a good idea for such arguments, regardless of the possibility of extending the set.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.