Re: [boost] [Review] Final Few Days for Formal Review ofProposed Boost.Ratio Library

Subject: Re: [boost] [Review] Final Few Days for Formal Review ofProposed Boost.Ratio Library
From: vicente.botet (vicente.botet_at_[hidden])
Date: 2010-10-08 12:48:20

----- Original Message ----- 
From: "Daniel Andersson" <Daniel.Andersson_at_[hidden]>
To: <boost_at_[hidden]>
Sent: Friday, October 08, 2010 2:41 PM
Subject: Re: [boost] [Review] Final Few Days for Formal Review ofProposed Boost.Ratio Library

> This is not a review, just a question about what the library is
> supposed to implement.
> 
> It appears that the implementation of the ratio arithmetic follows the
> specification in n2798. The comments at the top of ratio.hpp also links
> to n2798. The specification for ratio arithmetic has since changed. In
> n3126, the specification of ratio_add reads:
> 
> "The type ratio_add<R1, R2> shall be a synonym for ratio<T1, T2> where
> T1 has the value R1::num * R2::den + R2::num * R1::den and T2 has the
> value R1::den * R2::den."

Hi,

Yes this is an incompatibility of the current implementation. Others have already made the remark and I will change to the last wording of n3126. As the ratio class has already the nested typedef type it would be no interface break with the current interface.

Best,
Vicente