Re: [boost] [1.45] Typeof fixed, point release? (was: Boost 1.45 compile error)

Subject: Re: [boost] [1.45] Typeof fixed, point release? (was: Boost 1.45 compile error)
From: Hartmut Kaiser (hartmut.kaiser_at_[hidden])
Date: 2010-11-21 17:29:50

> I have just fixed the typeof problem on the release branch. (I've also
> verified that it makes the common_type regression go away without causing
> additional failures for either the typeof or type_traits libraries.)
> 
> I know it's not our policy to issue point releases, but totally breaking a
> major header (boost/type_traits.hpp) for a primary test compiler
> (msvc-7.1) seems like a good reason to make an exception. Does anybody
> feel otherwise?
> 
> The changelist containing the fix is 66662. I suggest we wait for tests to
> cycle and issue 1.45.1 asap.

Could we merge the patch for the Spirit issue
(https://svn.boost.org/trac/boost/ticket/4871) to the release branch for
this as well?

Regards Hartmut
---------------
http://boost-spirit.com

> 
> Thoughts?
> 
> Eric
> 
> 
> On 11/20/2010 12:41 PM, Peder Holt wrote:
> > This problem has been fixed on the trunk version for a while, but I
> > haven't managed to integrated this to the release branch.
> > Sorry about that.
> >
> > Regards
> > Peder
> >
> > 2010/11/20 Peder Holt <peder.holt_at_[hidden]>
> >
> >> The culprit is in line 156 in boost/typeof/msvc/typeof_impl.hpp # if
> >> BOOST_WORKAROUND(BOOST_MSVC,==1310)
> >> This entire if branch should be removed. A minimal fix for this
> >> release is to change from 1310 to some other arbitrary non-version
> number.
> >> I have no idea why the typeof regression tests does not pick up this
> error.
> >>
> >> Regards
> >> Peder
> >>
> >> 2010/11/20 Peder Holt <peder.holt_at_[hidden]>
> >>
> >> 2010/11/20 Vicente BOTET <vicente.botet_at_[hidden]>
> >>>
> >>>> Message du 20/11/10 14:52
> >>>>> De : "Eric Niebler"
> >>>>> A : boost_at_[hidden]
> >>>>> Copie à :
> >>>>> Objet : Re: [boost] Boost 1.45 compile error
> >>>>>
> >>>>> On 11/20/2010 7:25 AM, John Maddock wrote:
> >>>>>>>>> This sounds bad. Can anybody confirm?
> >>>>>>>>
> >>>>>>>> The tests already confirm it .
> >>>>>>>
> >>>>>>> Crap. Might I suggest we pull the release and reissue as a point
> >>>> release
> >>>>>>> after this is fixed?
> >>>>>>>
> >>>>>>> Adding back the missing context:
> >>>>>>
> >>>>>> Is this type_traits specific, or should boost.typeof work on that
> >>>>>> platform... I'm sure it used to?
> >>>>>
> >>>>> I don't know. Is common_type the only trait to use boost.typeof?
> >>>>> If so, can we just comment out the #include of common_type.hpp in
> >>>>> type_traits.hpp as a stop-gap?
> >>>>>
> >>>>>> BTW there are a *lot* of failures with VC7.1 relating to this.
> >>>>
> >>>> Most  of the failures if not all are due to the includion of
> >>>> common_type.hpp.
> >>>>
> >>>>> By "this" do you mean the type_traits error or the boost.typeof
> >>>> failure?
> >>>>>
> >>>>
> >>>> As Boost.Typeof is Ok with this compiler we can not say yet that
> >>>> the problem is with Boost.Typeof.
> >>>> Surprisingly the same compiler in trunk works "daw-msvc71  rev
> >>>> 66640 Fri, 19 02:00:37 +0000i msvc- 7.1"
> >>>>
> >>>> daw-msvc71  rev 66641 Fri, 19 Nov 2010 09:00:32 +0000i fails on
> release.
> >>>>
> >>>> From my part we can comment the #inlcude for common_type from the
> >>>> type_traits.hpp file. Applications that want to use common_type can
> >>>> include  for the moment.
> >>>>
> >>>>
> >>> I will install Visual Studio 2003 ASAP and try to see if there is
> >>> something obviously wrong with boost.typeof for this compiler.
> >>>
> >>> Regards
> >>> Peder
> >>>
> >>>
> >>>> Best,
> >>>> Vicente
> >>>> _______________________________________________
> >>>> Unsubscribe & other changes:
> >>>> http://lists.boost.org/mailman/listinfo.cgi/boost
> >>>>
> >>>
> >>>
> >>
> > _______________________________________________
> > Unsubscribe & other changes:
> > http://lists.boost.org/mailman/listinfo.cgi/boost
> >
> 
> --
> Eric Niebler
> BoostPro Computing
> http://www.boostpro.com
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost