Re: [boost] [gil::io] Feedback for scanline_read_iterator

Subject: Re: [boost] [gil::io] Feedback for scanline_read_iterator
From: Mateusz Loskot (mateusz_at_[hidden])
Date: 2013-02-14 09:42:33

On 14 February 2013 12:04, Mateusz Loskot <mateusz_at_[hidden]> wrote:
> On 12 February 2013 01:13, Christian Henning <chhenning_at_[hidden]> wrote:
>>
>> I'm getting close to finally commit the new io extension for
>> boost::gil. As it was required from the boost review I have
>> implemented a basic image_read_iterator to read large images.
>
> Hi Christian,
>
> It's great to see it rolling forward.
>
>> I would like to get some feedback on my interface and maybe on the actual
>> implementation, as well. I must admit this is my first iterator that I
>> have designed and implemented from scratch with some help by other people.
>
> I have update my clone of GIL IOv2 and briefly played with your
> example a bit [1]
> using VS 2012 on Windows 8. FYI, your example compiles and runs well.
>
> [1] https://github.com/mloskot/boost-gil-workshop
>
> A few questions from me:
> [...]

5) Have you considered boost::iterator_facade to avoid much of the boilerplate?

Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net