Subject: Re: [boost] [Stacktrace] Second review begins today 17th Mar ends 26th Mar
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2017-03-19 06:17:30
2017-03-18 17:39 GMT+03:00 Peter Dimov via Boost <boost_at_[hidden]>:
> Antony Polukhin wrote:
>> windows.h is a minor problem of a single platform.
> windows.h is not a minor problem at all. It defines one million macros.
>> It already has an ultimate fix - use the non header-only version of the
> This is not a decision that a library developer can make. If I'm writing a
> header-only library (that does nothing Windows-specific), I absolutely
> CANNOT afford to include <windows.h>, which means that I can't include
> stacktrace.hpp. Whether BOOST_STACKTRACE_LINK is defined is not up to me.
I've tried to move code around and separate the headers and I've
failed. Headers+docs on non MS platforms start to look ugly, code does
not compile separately from non COM parts or just becomes useless or
COM headers leak everywhere. I'd appreciate a pull request, this issue
is beyond my fixing capabilities.
-- Best regards, Antony Polukhin
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk