Subject: Re: [boost] [Boost-users] [Stacktrace] Review 2 Manager report
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2017-03-31 07:09:03
2017-03-30 9:54 GMT+03:00 Niall Douglas via Boost-users
> Many thanks to all those who participated in the second review of
> proposed Boost.Stacktrace. I received the following formal reviews:
> 1. Peter Dimov (ACCEPT)
> 2. Vladimir Batov (ACCEPT)
> 3. Artyom Bellis (CONDITIONAL ACCEPT)
> 4. Bjorn Reese (ACCEPT)
> 5. Edward Diener (ACCEPT)
> Extensive comments without a formal recommendation were also made by:
> 1. Mark Bartosik
> 2. Florian Weimer
Great thanks to all the reviewers and commenter!
I'm open to comments and suggestions after the review too.
> Some of the more important conditions for acceptance as judged by the
> review manager are:
> * Problems on FreeBSD (and by inference OS X?).
> * Per frame execution of addr2line rather than calling it once.
> * Throw-with-trace was asked for by a lot of people.
> * One reviewer suggested that the addr2line backend was async signal
> unsafe. My reading of the code is that it is async signal unsafe to
> parse a stacktrace (and unavoidably so on any platform), but the capture
> of backtraces is now fully async signal safe.
> * Some disliked the bringing in of windows.h and the COM headers on
> Windows. For a header only library I consider this acceptable,
> Stacktrace when configured in non-header only mode does not inject
> windows.h into everything including stacktrace.
I'll be fixing the library and hardening the tests for next months.
There were much more comments and I'll try to address all of them.
> Congratulations to Antony on getting yet another library of his
> into Boost!
> ned Productions Limited Consulting
> http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/
Great thanks to Niall for managing the library review (twice)!
-- Best regards, Antony Polukhin