Re: [release] Boost 1.85.0

From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2024-05-23 23:43:00

On 5/24/24 02:12, Marshall Clow wrote:
> On May 23, 2024, at 3:04 PM, Andrey Semashev via Boost
> <boost_at_[hidden]> wrote:
>>
>> On 5/21/24 10:08, Andrey Semashev wrote:
>>>
>>> For Boost.Log, the boost-1.85.0 tag is pointing to the wrong commit:
>>>
>>> e79cfd841f90e4f0d7f4729440e7ef92ef7495da
>>>
>>> It should point to:
>>>
>>> 2d932ddcb5b05a9b2cc0a9df2d8a6ff88883f2b3
>>>
>>> which is the last commit in the series that were merged to master (with
>>> permission) right before the release. I can see the changes in that
>>> commit are present in the 1.85.0 .tar.bz2 archive from jfrog, and are
>>> also present on the website.
>>
>> Ping? Should I fix the tag myself?
> 
> Sorry - I've been head down in some other stuff.
> 
> But I’ve been reading the git-tag documentation
> on https://git-scm.com/docs/git-tag#:~:text=If%20you%20got%20the%20wrong,you%20have%20the%20new%20version. <https://git-scm.com/docs/git-tag#:~:text=If%20you%20got%20the%20wrong,you%20have%20the%20new%20version.>
> 
> Where it talks about “fixing” a tag.
> Have you read that?
> 
>> # On Re-tagging
>> What should you do when you tag a wrong commit and you would want to
>> re-tag?
>>
>> If you never pushed anything out, just re-tag it. Use "-f" to replace
>> the old one. And you’re done.
>>
>> But if you have pushed things out (or others could just read your
>> repository directly), then others will have already seen the old tag.
>> In that case you can do one of two things:
>>
>> The sane thing. Just admit you screwed up, and use a different name.
>> Others have already seen one tag-name, and if you keep the same name,
>> you may be in the situation that two people both have "version X", but
>> they actually have different "X"'s. So just call it "X.1" and be done
>> with it.
>>
>> The insane thing. You really want to call the new version "X" too,
>> even though others have already seen the old one. So just use git tag
>> -f again, as if you hadn’t already published the old one.

I did read it now, and I think it still makes sense to fix it.

By the way, checking out boost-1.85.0 of the superproject, I can see it
references Boost.Log commit 2d932ddcb5b05a9b2cc0a9df2d8a6ff88883f2b3
(the correct one). The superproject was updated to reference this commit
in 45b56569ecf9e256bc4e0cc01846ecadcacb91c1.

So, currently, the superproject's tag boost-1.85.0 does not reference
Boost.Log's boost-1.85.0. Which is another reason to fix the tag in
Boost.Log.